-
Notifications
You must be signed in to change notification settings - Fork 91
feat: true zero-downtime deployment with container draining #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, @wowu. This looks fantastic! I'm looking forward to the rollout of this feature. 🚀 |
|
What a great timing, I literally adopted this in my project solving exactly this issue, thinking it was a feature since the start, but I somehow missed it when I did the original implementation - but no, it was just merged 15min before me going to look for something like it. Thank you both :) |
|
@jippi I'm really glad it's useful since day 1 😄 Can you tell me more about your use case? How are you running docker-rollout? |
|
@wowu I'm using it on MangaBaka which is an app built with SvelteKit. I run 3 x web containers and 3 x API containers, and want them to roll out without dropping traffic. They are fronted by nginx-proxy that handles everything else. Implementation wise, I raw copy+pasted the config from the docs and adjusted the |
|
Cool! And how do you build and deploy and new container versions? I wonder how docker rollout fits in the process, is it used as a part of a deploy script or CI/CD pipeline? |
|
I deploy to a single host via GitLab CI runners :) |
|
Cool, thanks for sharing 😃 |
Changes:
--pre-stop-hookargument.Notes:
--drainwith the same implementation, so users can actually understand the processClose #21, #32.